Extend blocked_nd_range CTAD with tests and explicit deduction guide #1525
+99
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
kboyarinov
force-pushed
the
rarutyun/blocked_range_nd_class
branch
from
3fe65dc to
64610c6
Compare
… into dev/kboyarinov/blocked_range_nd_deduction_guides_test
kboyarinov
changed the title
kboyarinov
requested review from
vossmjp,
akukanov,
pavelkumbrasev and
rarutyun
… into dev/kboyarinov/blocked_range_nd_deduction_guides_test
akukanov
reviewed
Jan 14, 2025
Comment on lines
+170
to
+177
| template <typename Value, unsigned int N> | ||
| blocked_nd_range(blocked_nd_range<Value, N>, oneapi::tbb::split) | ||
| -> blocked_nd_range<Value, N>; | ||
|
|
||
| template <typename Value, unsigned int N> | ||
| blocked_nd_range(blocked_nd_range<Value, N>, oneapi::tbb::proportional_split) | ||
| -> blocked_nd_range<Value, N>; | ||
|
|
There was a problem hiding this comment.
Splitting constructors are not really for users but for algorithms. Do we need deduction guides for these?
Comment on lines
+161
to
+165
| template <typename Value, unsigned int N, | ||
| typename = std::enable_if_t<(N != 2 && N != 3)>> | ||
| blocked_nd_range(const Value (&)[N]) | ||
| -> blocked_nd_range<Value, N>; | ||
|
|
There was a problem hiding this comment.
What if the argument is explicitly an array of 2 or 3 elements, not a braced init list? Seems there is no deduction guide for it.
| #if __TBB_CPP17_DEDUCTION_GUIDES_PRESENT | ||
| //! Testing blocked_rangeNd deduction guides | ||
| //! \brief \ref interface | ||
| TEST_CASE("blocked_rangeNd deduction guides") { |
There was a problem hiding this comment.
The test misses any checks for constructing explicitly from an array. It needs to check construction from arrays of different sizes (incl. 2 and 3), with and without a grainsize argument.
Comment on lines
+304
to
+306
| oneapi::tbb::blocked_range<int> dim_range(0, 100); | ||
|
|
||
| blocked_nd_range<int, 2> source_range(dim_range, dim_range); |
There was a problem hiding this comment.
Can we test with something more fancy than int for the value type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a comprehensive description of proposed changes
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information