Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning: Compatibility with CMake < 3.10 will be removed from a future version of CMake #1585

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

phprus
Copy link
Contributor

@phprus phprus commented Dec 17, 2024

Description

Fix CMake deprecation warning:

CMake Deprecation Warning at CMakeLists.txt:15 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

https://cmake.org/cmake/help/v3.31/command/cmake_minimum_required.html

Fixes # - issue number(s) if exists

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

@phprus phprus force-pushed the cmake-1 branch 2 times, most recently from c86c83d to 53c7a7d Compare December 17, 2024 16:07
@phprus phprus force-pushed the cmake-1 branch 2 times, most recently from 57bfc8e to 310ad9a Compare January 2, 2025 11:20
@phprus
Copy link
Contributor Author

phprus commented Jan 2, 2025

Rebased

Copy link
Contributor

@isaevil isaevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One small comment though.

CMakeLists.txt Show resolved Hide resolved
…ved from a future version of CMake.

Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@isaevil isaevil merged commit f0985b1 into uxlfoundation:master Jan 14, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants