Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capital letters in Polish translation #1890

Merged
merged 1 commit into from
May 13, 2016

Conversation

marioosh-net
Copy link
Contributor

No description provided.

@acrobat
Copy link
Member

acrobat commented May 13, 2016

I saw that in PR #1340 all names were converted to lowercase and I found this on wikipedia

Names are generally capitalized in Polish as in English. Polish does not capitalize the months and days of the week, nor adjectives and other forms derived from proper nouns (for example, angielski "English").

Source

So I guess we should keep them lowercase

@marioosh-net
Copy link
Contributor Author

Generally You are right - in the middle of a sentence the names of months and days in the Polish language are written in lowercase, but in context of something like the calendar is absolutely correct. I am Polish ;)

@acrobat acrobat added this to the 1.7.0 milestone May 13, 2016
@acrobat
Copy link
Member

acrobat commented May 13, 2016

Ok great, just wanted to check we don't override changes that should be kept! Thanks @marioosh-net

@acrobat acrobat merged commit fbbd4d7 into uxsolutions:master May 13, 2016
@acrobat acrobat mentioned this pull request May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants