-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RTL layout #1973
Fix RTL layout #1973
Conversation
* Fix RTL width. * Fix position of arrow/caret. * Add build artifacts.
Not sure if it was helpful to include the build artifacts. Here's the core change: nwhittaker@ef6244b. |
Thanks for the pr @nwhittaker! But can revert the changes on the dist files and just keep the core changes to the js and less files Thanks! |
This reverts commit 91779fb.
Here’s another attempt to fix the RTL width issue.
Sorry about that -- wasn't sure what the procedure was. Should look a little better now. |
Thanks @nwhittaker, can you provide a jsfiddle example to show that the issue is resolved? As I don't seem to see a difference with the current code |
Looks like I had a problem with the specificity of the CSS selector and the standalone stylesheet. I'll push a fix. In case it's still useful, here's a fiddle of the existing behavior, and one showing the issue resolved. |
How are we looking? |
@acrobat, what are your intentions with this PR? |
This fixes an issue that I've been running into - @acrobat can we get a merge here? |
@acrobat could you please merge this? |
Sorry for the late answer, I've been on vacation the last few days. Pr is merged in master and will be included in 1.7.0 Thanks @nwhittaker |
this.picker.css({ this worked for me :) |
I believe this fixes the issue where RTL layouts blow out the width of the picker. Specifically, the left side of the picker appears to extend to the left side of the viewport.
Adds build artifacts.