Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTL layout #1973

Merged
merged 4 commits into from
Aug 19, 2016
Merged

Fix RTL layout #1973

merged 4 commits into from
Aug 19, 2016

Conversation

nwhittaker
Copy link
Contributor

@nwhittaker nwhittaker commented Aug 9, 2016

I believe this fixes the issue where RTL layouts blow out the width of the picker. Specifically, the left side of the picker appears to extend to the left side of the viewport.

  • Fixes RTL width.
  • Adjusts position of arrow/caret to the right side of the picker.
  • Adds build artifacts.

* Fix RTL width.
* Fix position of arrow/caret.
* Add build artifacts.
@nwhittaker
Copy link
Contributor Author

Not sure if it was helpful to include the build artifacts. Here's the core change: nwhittaker@ef6244b.

@acrobat
Copy link
Member

acrobat commented Aug 9, 2016

Thanks for the pr @nwhittaker! But can revert the changes on the dist files and just keep the core changes to the js and less files

Thanks!

Here’s another attempt to fix the RTL width issue.
@nwhittaker
Copy link
Contributor Author

But can revert the changes on the dist files and just keep the core changes to the js and less files

Sorry about that -- wasn't sure what the procedure was. Should look a little better now.

@acrobat
Copy link
Member

acrobat commented Aug 9, 2016

Thanks @nwhittaker, can you provide a jsfiddle example to show that the issue is resolved? As I don't seem to see a difference with the current code

@nwhittaker
Copy link
Contributor Author

nwhittaker commented Aug 9, 2016

Looks like I had a problem with the specificity of the CSS selector and the standalone stylesheet. I'll push a fix.

In case it's still useful, here's a fiddle of the existing behavior, and one showing the issue resolved.

@nwhittaker
Copy link
Contributor Author

How are we looking?

@nwhittaker
Copy link
Contributor Author

@acrobat, what are your intentions with this PR?

@timmorey
Copy link

This fixes an issue that I've been running into - @acrobat can we get a merge here?

@musabsudan
Copy link

@acrobat could you please merge this?

@acrobat acrobat added this to the 1.7.0 milestone Aug 19, 2016
@acrobat
Copy link
Member

acrobat commented Aug 19, 2016

Sorry for the late answer, I've been on vacation the last few days. Pr is merged in master and will be included in 1.7.0

Thanks @nwhittaker

@acrobat acrobat merged commit d0df93c into uxsolutions:master Aug 19, 2016
@Me1o
Copy link

Me1o commented Mar 5, 2017

this.picker.css({
top: o,
left: n,
right: n,
zIndex: j
});

this worked for me :)

@acrobat acrobat mentioned this pull request May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants