Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the main.tf libvirt examples to use container server #1518

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Feb 28, 2024

What does this PR change?

See the title.

Copy link
Member

@renner renner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested any of the configurations, but it looks good. Thanks for the update!

main.tf.libvirt.example.Manager-43 Show resolved Hide resolved
uri = "qemu:///system"
}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

# "ubuntu2004o", "ubuntu2204o"
# to see what VM uses what image, have a look at the image variable in the cucumber_module definition
# https://github.com/uyuni-project/sumaform/blob/master/modules/cucumber_testsuite/main.tf
images = ["rocky9o", "opensuse154o", "sles15sp4o", "ubuntu2204o"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it on purpose that we are not using SLSE15 SP5 here and below? I believe the image should be available as I was using it for a local deployment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same than for the other file: that avoids adding one more image to the mix.

@cbosdo cbosdo merged commit 2564d92 into uyuni-project:master Feb 28, 2024
2 checks passed
@cbosdo cbosdo deleted the container-doc branch February 28, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants