-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the main.tf libvirt examples to use container server #1518
Conversation
aa3a6c2
to
ba8183e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not tested any of the configurations, but it looks good. Thanks for the update!
uri = "qemu:///system" | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# "ubuntu2004o", "ubuntu2204o" | ||
# to see what VM uses what image, have a look at the image variable in the cucumber_module definition | ||
# https://github.com/uyuni-project/sumaform/blob/master/modules/cucumber_testsuite/main.tf | ||
images = ["rocky9o", "opensuse154o", "sles15sp4o", "ubuntu2204o"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it on purpose that we are not using SLSE15 SP5 here and below? I believe the image should be available as I was using it for a local deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same than for the other file: that avoids adding one more image to the mix.
What does this PR change?
See the title.