make sumaform terraform v11 compatible #387

MalloZup · 2018-07-24T09:24:45Z

This pr is not taking care of the update to v11 , it is a prerequisite step that we need to implement.

fix #285

Left to do:

gitlab

https://gitlab.suse.de/galaxy/sumaform-test-runner/merge_requests/41

backup centos7 or sles img

communication:

send an-email to galaxy-devel about the change of API (version != product_version)

moio

see inline comments
modules/libvirt/pts/minion-dump.mp and modules/openstack/pts/minion-dump.mp binary files should not change

moio · 2018-07-25T09:14:32Z

README_ADVANCED.md

@@ -1,10 +1,10 @@
 # Advanced `main.tf` configurations

-## Changing product versions
+## Changing product version


versions was OK here

moio · 2018-07-25T09:14:49Z

README_ADVANCED.md

@@ -191,11 +191,11 @@ module "min" {
 }
 ```

-## Change the base OS for supported SUSE Manager versions
+## Change the base OS for supported SUSE Manager product_versions


versions was OK here

moio · 2018-07-25T09:15:30Z

README_ADVANCED.md


-You can specifiy a base OS for `suse_manager` modules by specifying an `image` variable. There is a default selection if nothing is specified. Please note that not all SUSE Manager versions support all OSs, refer to official documentation to select a compatible OS. In particular, `opensuse423` can presently only be used for the `head` version.
+You can specifiy a base OS for `suse_manager` modules by specifying an `image` variable. There is a default selection if nothing is specified. Please note that not all SUSE Manager product_versions support all OSs, refer to official documentation to select a compatible OS. In particular, `opensuse423` can presently only be used for the `head` product_version.


Please double check all documentation or other non-code places. product_versions should be only changed in code, examples, and explicit references to code.

moio · 2018-07-25T09:17:52Z

modules/openstack/minion/variables.tf

-variable "version" {
-  description = "A valid SUSE Manager version (eg. 3.0-nightly, head) see README_ADVANCED.md"
+variable "product_version" {
+  description = "A valid SUSE Manager product_version (eg. 3.0-nightly, head) see README_ADVANCED.md"


version was correct here

@moio ok i can check the stuff, is really not easy to check all the stuff manually 🤕

MalloZup · 2018-07-25T13:25:08Z

gitlab

https://gitlab.suse.de/galaxy/sumaform-test-runner/merge_requests/41

obs submissions:

https://build.opensuse.org/request/show/631933

moio

Almost there:

one last inline comment
please update required_version = ">= 0.10.7" blocks throughout the codebase to request Terraform 0.11.x (we want users to upgrade to that version and we are already pretty certain 0.12 will break sumaform at this point)

moio · 2018-07-26T06:04:30Z

README_ADVANCED.md

-Some modules have a ``version`` variable that determines the software version. Specifically:
- * in `suse_manager`, `suse_manager_proxy` etc. `version` determines the SUSE Manager product version,
- * in `minion`, `client`, etc. `version` determines the SUSE Manager Tools version.
+Some modules have a ``product_version`` variable that determines the software product version. Specifically:


Double backticks here

juliogonzalez

I could not find any problem, but I'd strongly suggest using grep with the branch used for the PR, to see that we are not missing anything :-)

moio

Two more corner cases caught.

Apart from those this PR could be merged but we can't do that before having a terraform package that builds on Leap 15. Just too many people are on that distro.

I am fine with a patch that disables that test.

moio · 2018-07-26T13:38:18Z

main.tf.openstack-testsuite.example

@@ -1,5 +1,5 @@
 provider "openstack" {
-  version = "~> 1.2"
+  product_version = "~> 1.2"


This is wrong, as version is an internal variable of the provider in this case.

moio · 2018-07-26T13:38:32Z

main.tf.openstack.example

@@ -1,5 +1,5 @@
 provider "openstack" {
-  version = "~> 1.2"
+  product_version = "~> 1.2"


Bischoff

LGTM

with pessimistic operator

in bridged mode we need it, so is better to use it always

MalloZup requested a review from moio July 24, 2018 10:28

moio suggested changes Jul 25, 2018

View reviewed changes

MalloZup requested a review from mcalmer July 25, 2018 13:11

moio suggested changes Jul 26, 2018

View reviewed changes

MalloZup force-pushed the terraform-v11 branch from 3d91693 to 3c3861d Compare July 26, 2018 10:29

juliogonzalez approved these changes Jul 26, 2018

View reviewed changes

moio suggested changes Jul 26, 2018

View reviewed changes

moio mentioned this pull request Aug 1, 2018

exporter packages include services #372

Merged

mbologna mentioned this pull request Aug 8, 2018

[Depends on PR#387] Two more changes for terraform v11 #393

Closed

MalloZup force-pushed the terraform-v11 branch from 915de64 to 93121ba Compare August 20, 2018 14:06

uyuni-project deleted a comment from Bischoff Aug 20, 2018

uyuni-project deleted a comment from moio Aug 20, 2018

uyuni-project deleted a comment from Bischoff Aug 20, 2018

MalloZup requested a review from Bischoff August 20, 2018 14:11

uyuni-project deleted a comment from Bischoff Aug 20, 2018

uyuni-project deleted a comment from juliogonzalez Aug 20, 2018

Bischoff approved these changes Aug 21, 2018

View reviewed changes

MalloZup added 10 commits August 23, 2018 10:40

Adapt advanced readme.md with product_version

54e8405

modify example file for having product_version

26a0271

adapt modules to have product_version

28b9421

adapt travis-ci for new grain product_version

e89df74

adapt salt grains to use product_version

ed536ac

apply version instead of product_version

9640b37

change description for clients

2572cfe

restore version in readme

5ff188d

restore bin

3f9a4b2

update required version

2176919

with pessimistic operator

MalloZup added 3 commits August 23, 2018 10:40

remove double backticks

767e71a

fix version

000a7d0

add product_version for newer files

be4b39b

MalloZup force-pushed the terraform-v11 branch from 065fcd9 to be4b39b Compare August 23, 2018 08:41

MalloZup changed the title ~~WIP: make sumaform terraform v11 compatible~~ make sumaform terraform v11 compatible Aug 23, 2018

add qemu-agent var true for enabling qemu-agent

740c5ab

in bridged mode we need it, so is better to use it always

MalloZup force-pushed the terraform-v11 branch from 2d8d99b to 740c5ab Compare August 27, 2018 11:30

uyuni-project deleted a comment from moio Aug 28, 2018

uyuni-project deleted a comment from juliogonzalez Aug 28, 2018

uyuni-project deleted a comment from moio Aug 28, 2018

uyuni-project deleted a comment from juliogonzalez Aug 28, 2018

MalloZup merged commit b4673ec into uyuni-project:master Aug 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make sumaform terraform v11 compatible #387

make sumaform terraform v11 compatible #387

MalloZup commented Jul 24, 2018 •

edited

Loading

moio left a comment

moio Jul 25, 2018

moio Jul 25, 2018

moio Jul 25, 2018

MalloZup Jul 25, 2018

moio Jul 25, 2018

MalloZup Jul 25, 2018

MalloZup commented Jul 25, 2018 •

edited

Loading

moio left a comment

moio Jul 26, 2018

juliogonzalez left a comment

moio left a comment

moio Jul 26, 2018

moio Jul 26, 2018

Bischoff left a comment


		You can specifiy a base OS for `suse_manager` modules by specifying an `image` variable. There is a default selection if nothing is specified. Please note that not all SUSE Manager versions support all OSs, refer to official documentation to select a compatible OS. In particular, `opensuse423` can presently only be used for the `head` version.
		You can specifiy a base OS for `suse_manager` modules by specifying an `image` variable. There is a default selection if nothing is specified. Please note that not all SUSE Manager product_versions support all OSs, refer to official documentation to select a compatible OS. In particular, `opensuse423` can presently only be used for the `head` product_version.

make sumaform terraform v11 compatible #387

make sumaform terraform v11 compatible #387

Conversation

MalloZup commented Jul 24, 2018 • edited Loading

Left to do:

gitlab

backup centos7 or sles img

communication:

moio left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MalloZup commented Jul 25, 2018 • edited Loading

gitlab

obs submissions:

moio left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juliogonzalez left a comment

Choose a reason for hiding this comment

moio left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Bischoff left a comment

Choose a reason for hiding this comment

MalloZup commented Jul 24, 2018 •

edited

Loading

MalloZup commented Jul 25, 2018 •

edited

Loading