Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move schema upgrade file to the right directory #9119

Conversation

meaksh
Copy link
Member

@meaksh meaksh commented Jul 29, 2024

What does this PR change?

We just noticed that the schema migration file that was introduced here: #9065, is probably not in the right place.

It was added to susemanager-schema-5.0.8-to-susemanager-schema-5.0.9/ while at the time of merging the PR there was already a newer directory: susemanager-schema-5.0.10-to-susemanager-schema-5.0.11/

Probably during one of the latest rebases of the PR, a new directory of the schema migration was created and went unnoticed, so actually, the mentioned schema migration file would need to go there.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: tests not needed

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/24426
Port(s): https://github.com/SUSE/spacewalk/pull/24882

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not new enough. Current version is already 5.0.10.
So to perform the migration again you need to put it into 5.0.10-to-5.0.11

@meaksh meaksh force-pushed the master-fix-place-for-schema-migration-file branch from 38e46e6 to f3735c8 Compare July 29, 2024 15:38
@meaksh meaksh requested a review from mcalmer July 29, 2024 15:38
@deneb-alpha deneb-alpha merged commit a93b3db into uyuni-project:master Jul 29, 2024
20 of 21 checks passed
@meaksh meaksh deleted the master-fix-place-for-schema-migration-file branch July 31, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants