♻️ refactor: 分割代入時に大文字始まりの変数とし、不要な代入を削除する

uyupun · Mar 23, 2024 · 88195fb · 88195fb
1 parent c664c72
commit 88195fb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/src/components/base/Heading/index.tsx b/src/components/base/Heading/index.tsx
@@ -20,12 +20,11 @@ type BaseProps<T extends TagName> = {
 type Props<T extends TagName> = BaseProps<T> &
   Omit<ComponentPropsWithoutRef<T>, keyof BaseProps<T>>;
 
-const Heading: FC<Props<TagName>> = ({ tag = 'h1', children, className, ...rest }) => {
-  const Component = tag;
+const Heading: FC<Props<TagName>> = ({ tag: Tag = 'h1', children, className, ...rest }) => {
   return (
-    <Component className={clsx(styles.common, styles[tag], className)} {...rest}>
+    <Tag className={clsx(styles.common, styles[Tag], className)} {...rest}>
       {children}
-    </Component>
+    </Tag>
   );
 };
 

diff --git a/src/components/base/Text/index.tsx b/src/components/base/Text/index.tsx
@@ -33,7 +33,7 @@ type Props<T extends TagName> = BaseProps<T> &
   Omit<ComponentPropsWithoutRef<T>, keyof BaseProps<T>>;
 
 const Text: FC<Props<TagName>> = ({
-  tag = 'span',
+  tag: Tag = 'span',
   fontWeight = 'normal',
   fontStyle = 'normal',
   color = 'white',
@@ -44,15 +44,14 @@ const Text: FC<Props<TagName>> = ({
   const style = styles({
     color,
     fontWeight,
-    display: tag === 'span' ? 'inlineBlock' : 'block',
+    display: Tag === 'span' ? 'inlineBlock' : 'block',
     fontStyle,
   });
-  const Component = tag;
 
   return (
-    <Component className={clsx(style, className)} {...rest}>
+    <Tag className={clsx(style, className)} {...rest}>
       {children}
-    </Component>
+    </Tag>
   );
 };