Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSONの設定をYAMLに変更 #331

Merged
merged 3 commits into from
Dec 5, 2023
Merged

JSONの設定をYAMLに変更 #331

merged 3 commits into from
Dec 5, 2023

Conversation

tyokinuhata
Copy link
Member

@tyokinuhata tyokinuhata commented Dec 4, 2023 •
edited
Loading

@tyokinuhata tyokinuhata self-assigned this Dec 4, 2023
@uyupunpopunpo
Copy link
Contributor

Storybook URL: https://uyupun.github.io/official/feat_json_to_yml/storybook/
Lighthouse URL: https://uyupun.github.io/official/feat_json_to_yml/lighthouse/

takashi0602
takashi0602 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@takashi0602 takashi0602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コマンド動いてました！
LGTM👍

@tyokinuhata tyokinuhata merged commit 2c437d1 into main Dec 5, 2023
3 checks passed
@tyokinuhata tyokinuhata deleted the feat/json_to_yml branch December 5, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takashi0602 takashi0602 takashi0602 approved these changes

Assignees

@tyokinuhata tyokinuhata

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tyokinuhata @uyupunpopunpo @takashi0602