バッジコンポーネントの修正 #335
Closed
バッジコンポーネントの修正 #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook URL: https://uyupun.github.io/official/fix_305_badge/storybook/ |
|
現状はバッジは技術スタックを表示するためににしか使わないので問題にはならないものの、本来バッジコンポーネントが |
|
それはそうっすね... |
takashi0602
commented
Dec 9, 2023
Comment on lines
+20
to
+21
| Expo: '#000000', | ||
| FastApi: '#009485', |
There was a problem hiding this comment.
大文字で始まるのは違和感があるが、良い方法が思い浮かばない🤔
ここだけ大文字でもええか〜という気もあるが、何か良い案とかあります？
↓みたいな配列を定義して、これをkeyに使うとかでも良いんかなと思ったり...🤔
const technologies = ['Expo', 'FastApi'] as const;
There was a problem hiding this comment.
あとは今はこのファイルに置いてても良さそうやけど、このバッジコンポーネント使うページに technologyColors は定義するべきかも？
There was a problem hiding this comment.
technologyColors.Expo みたいな感じでアクセスできるなら個人的にはそんなに違和感ないな。コーディング規約的に大文字にするのはOKなんだっけ？
|
レビューしていただいて申し訳ないが、こちらはBCCDに沿って修正するということでCloseします |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #305
概要
Figmaのデザインが変更されたので、それに合わせてバッジコンポーネントのデザインを修正しました！
その他
PR #334 マージ後にOpenします