Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labelコンポーネントの修正 #338

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Labelコンポーネントの修正 #338

merged 4 commits into from
Dec 13, 2023

Conversation

takashi0602
Copy link
Member

@takashi0602 takashi0602 commented Dec 12, 2023

ref #305

概要

デザイン修正に伴い、Labelコンポーネントを修正しました。
デザイン上Labelでinputをラップするような構造にはならないため、childrenは削除しました🙏
確認お願いします!

その他

PR #337 マージ後にデフォルトで背景色が付くようになります

スクリーンショット

Storybook上にLabelコンポーネントが表示されている

@takashi0602 takashi0602 self-assigned this Dec 12, 2023
@uyupunpopunpo
Copy link
Contributor

Copy link
Member

@tyokinuhata tyokinuhata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM!!!!

@takashi0602 takashi0602 merged commit 04e5699 into main Dec 13, 2023
4 checks passed
@takashi0602 takashi0602 deleted the fix/305_label branch December 13, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants