Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@acab/reset.cssの導入 #350

Closed
wants to merge 3 commits into from
Closed

@acab/reset.cssの導入 #350

wants to merge 3 commits into from

Conversation

takashi0602
Copy link
Member

close #349

概要

modern-css-resetをアンインストールし、@acab/reset.cssを導入しました。ご確認よろしくお願いします🫡

@takashi0602 takashi0602 self-assigned this Jan 3, 2024
@uyupunpopunpo
Copy link
Contributor

Storybook URL: https://uyupun.github.io/official/chore_349_@acab-reset-css/storybook/
Lighthouse URL: https://uyupun.github.io/official/chore_349_@acab-reset-css/lighthouse/

@tyokinuhata
Copy link
Member

ボタンのレイアウトが崩れてる(というよりもボタンが長くなってる？)気がする

@tyokinuhata
Copy link
Member

いちおうスクショ

スクリーンショット 2024-01-04 1 28 04

@takashi0602
Copy link
Member Author

なんか全体的に崩れてそうな感じ💦

@takashi0602
Copy link
Member Author

こちらはスタイル崩れが激しかったためClose

@takashi0602 takashi0602 closed this Jan 4, 2024
@takashi0602 takashi0602 deleted the chore/349_@acab-reset-css branch January 22, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyokinuhata tyokinuhata tyokinuhata left review comments

Assignees

@takashi0602 takashi0602

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the-new-css-resetの導入
3 participants
@takashi0602 @uyupunpopunpo @tyokinuhata