Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the-new-css-resetの導入 #351

Merged
merged 5 commits into from
Jan 4, 2024
Merged

the-new-css-resetの導入 #351

merged 5 commits into from
Jan 4, 2024
+19 −14

Conversation

takashi0602
Copy link
Member

close #349

概要

modern-css-resetをアンインストールし、the-new-css-resetを導入しました。ご確認よろしくお願いします🫡

@takashi0602 takashi0602 self-assigned this Jan 4, 2024
@uyupunpopunpo
Copy link
Contributor

Storybook URL: https://uyupun.github.io/official/chore_349_the-new-css-reset/storybook/
Lighthouse URL: https://uyupun.github.io/official/chore_349_the-new-css-reset/lighthouse/

@takashi0602
Copy link
Member Author

上記コミットにより以下のように変更されました👍
Storybook上にテキストエリアが表示された画像
Storybook上にテキストボックスが表示された画像

tyokinuhata
tyokinuhata approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@tyokinuhata tyokinuhata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM

@takashi0602 takashi0602 merged commit 0907839 into main Jan 4, 2024
6 checks passed
@takashi0602 takashi0602 deleted the chore/349_the-new-css-reset branch January 4, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyokinuhata tyokinuhata tyokinuhata approved these changes

Assignees

@takashi0602 takashi0602

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the-new-css-resetの導入
3 participants
@takashi0602 @uyupunpopunpo @tyokinuhata