Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCCDデザインに関するドキュメントの作成 #367

Merged
merged 16 commits into from
Jan 27, 2024

Conversation

takashi0602
Copy link
Member

close #359

概要

BCCDデザインに関するドキュメントを作成しましたので確認お願いします。
※ (CSS in JSの良さでもあるが、)現状CSS設計は意識していないため、BEMの記述は削除しました。

@takashi0602 takashi0602 self-assigned this Jan 23, 2024
@uyupunpopunpo
Copy link
Contributor

docs/architecture.md Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
@tyokinuhata

This comment was marked as resolved.

docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
@takashi0602
Copy link
Member Author

ちなみに余談なんですが、CSS in JSを利用する限り、BEMみたいなCSS設計が絡んでくることは今後もない?(可能性が低い?)

可能性低いっすね🙏
現状コンポーネントごとにスタイルを記述してるので、CSSのスコープが小さくでき、CSS設計を意識せずに記述できるからっすね(CSS in JSではなくてもCSS Modulesとかも同じやと思う)

Copy link
Member

@tyokinuhata tyokinuhata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@takashi0602 takashi0602 merged commit 953071b into main Jan 27, 2024
6 checks passed
@takashi0602 takashi0602 deleted the docs/359_bccd branch January 27, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

コンポーネント化する際のBCCDの分類に迷わないようにドキュメントを作成する
3 participants