Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visionコンポーネントの作成 #377

Merged
merged 8 commits into from
Mar 27, 2024
Merged

Visionコンポーネントの作成 #377

merged 8 commits into from
Mar 27, 2024

Conversation

takashi0602
Copy link
Member

@takashi0602 takashi0602 commented Mar 23, 2024

概要

タイトル通り、Visionコンポーネントの作成をしました。

スクリーンショット

Storybookのスクリーンショット。PCサイズの時のVisionコンポーネントを描画している。 Storybookのスクリーンショット。PCサイズの時のVisionコンポーネントを描画している。

その他

PR #376 マージ後にマージします。

@takashi0602 takashi0602 self-assigned this Mar 23, 2024
@uyupunpopunpo
Copy link
Contributor

src/components/domain/Vision/index.tsx Outdated Show resolved Hide resolved
src/components/domain/Vision/index.tsx Outdated Show resolved Hide resolved
Base automatically changed from refactor/base-components to main March 23, 2024 17:01
@tyokinuhata
Copy link
Member

若干、Chromaticで差分出てたけどええんやろか

スクリーンショット 2024-03-24 23 29 41

@takashi0602
Copy link
Member Author

Textコンポーネントに当たっている方のスタイルが優先されてもうてるわ
Textコンポーネント少し修正します🙇‍♂️

@takashi0602
Copy link
Member Author

@tyokinuhata

PR #379 でTextコンポーネントを修正したので、先にこちらレビューお願いします🙇‍♂️

@takashi0602
Copy link
Member Author

@tyokinuhata

6b18afb こちらで対応しました!
また、スマホの時は24pxではなく20pxだったので合わせて修正しています🙏
https://www.figma.com/file/24u8W1q18DksKv8UmgUhpv/official?type=design&node-id=2330-4043&mode=design&t=2WmUKPuY3y00Vk7T-0

@takashi0602 takashi0602 requested a review from tyokinuhata March 27, 2024 10:44
Copy link
Member

@tyokinuhata tyokinuhata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@takashi0602 takashi0602 merged commit 4782027 into main Mar 27, 2024
6 checks passed
@takashi0602 takashi0602 deleted the feat/355_vision branch March 27, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants