Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the use of ServerName in ECH config #3188

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Fix the use of ServerName in ECH config #3188

merged 1 commit into from
Oct 12, 2024

Conversation

dyhkwong
Copy link
Contributor

@dyhkwong dyhkwong commented Oct 12, 2024 •
edited
Loading

#3162 (comment)

It seems that the original author took no action to fix it, so I raised this PR.

xiaokangwang
xiaokangwang approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@xiaokangwang xiaokangwang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I believe this pull request is ready to be merged. It also arrived at a nice timing just before new release are generated.

@xiaokangwang xiaokangwang merged commit 13bad86 into v2fly:master Oct 12, 2024
35 of 38 checks passed
@dyhkwong dyhkwong deleted the ech branch October 19, 2024 06:22
@BrewTestBot BrewTestBot mentioned this pull request Oct 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaokangwang xiaokangwang xiaokangwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyhkwong @xiaokangwang