Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor file system #142

Merged
merged 5 commits into from
Jan 18, 2021
Merged

Refactor file system #142

merged 5 commits into from
Jan 18, 2021

Conversation

siyuan0322
Copy link
Member

@siyuan0322 siyuan0322 commented Jan 13, 2021

Take advantage of fsspec to resolve common schemes.
Implement a customized oss driver.

@siyuan0322 siyuan0322 marked this pull request as draft January 13, 2021 09:22
@siyuan0322 siyuan0322 changed the base branch from dev/kubernetes to main January 15, 2021 10:47
Copy link
Member

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to submit a code-format PR first, using any formatter you would like. Such a code-format doesn't involves any semantic change.

Then rebase/reset/apply this PR on that.

modules/graph/loader/arrow_fragment_loader.h Show resolved Hide resolved
modules/io/CMakeLists.txt Show resolved Hide resolved
modules/io/python/requirements.txt Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #142 (45eef5b) into main (4b0a086) will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   63.56%   63.77%   +0.20%     
==========================================
  Files          53       53              
  Lines        3884     3884              
==========================================
+ Hits         2469     2477       +8     
+ Misses       1415     1407       -8     
Impacted Files Coverage Δ
src/common/util/status.h 41.75% <0.00%> (+2.19%) ⬆️
src/client/io.cc 69.90% <0.00%> (+5.82%) ⬆️

@siyuan0322 siyuan0322 marked this pull request as ready for review January 18, 2021 06:15
@sighingnow sighingnow merged commit 4a9f81f into v6d-io:main Jan 18, 2021
@siyuan0322 siyuan0322 deleted the zsy/io branch January 18, 2021 06:22
@sighingnow sighingnow linked an issue Jan 27, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants