Fix the sidecar can't work as expected and replace the kind version with v0.19.0 #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dashanji, Could you please
|
sighingnow
approved these changes
Jun 29, 2023
dashanji
changed the title
dashanji
force-pushed
the
fix-sidecar
branch
2 times, most recently
from
cb11481 to
176ad46
Compare
* Fix the bug the sidecar template is not injected into the workload yaml. * Fix the bug the workload yaml can't contains the special character like '/' during sidecar injection. * Add the ownerReferences to the Sidecar CR so that all injected resources will be deleted after deleting the workload. * Add a test case for testing the vineyard sidecar via kubectl. * Replace the kind version with v0.19.0 rather than v0.20.0. * Support to set the required job annotation as null string. Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue number
Related to #1355