Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add community related markdowns #144

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

andydiwenzhu
Copy link
Collaborator

What do these changes do?

Related issue number

Fixes

Copy link
Member

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Please add a "SECURITY.md" as well.

| [Tao He](mailto:linzhu.ht@alibaba-inc.com) | [sighingnow](https://github.com/sighingnow) | Alibaba |
| [Diwen Zhu](mailto:diwen.zdw@alibaba-inc.com) | [andydiwenzhu](https://github.com/andydiwenzhu) | Alibaba |
| [Siyuan Zhang](mailto:siyuanzhang.zsy@alibaba-inc.com) | [siyuan0322](https://github.com/siyuan0322) | Alibaba |
| [Wenyuan Yu](mailto:wenyuan.ywy@alibaba-inc.com) | [wenyuanyu](https://github.com/wenyuanyu) | Alibaba |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add weibin as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In alphabet order.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And xiaojian.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOVERNANCE.md Outdated

## Credits

Some contents in this documents have been borrowed from [OpenYurt](https://github.com/alibaba/openyurt/blob/master/GOVERNANCE.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the link to "OpenYurt".

@sighingnow
Copy link
Member

Overall looks good to me. Please add a "SECURITY.md" as well.

Something like https://github.com/standard/.github/blob/master/SECURITY.md

@sighingnow
Copy link
Member

Overall looks good to me. Please add a "SECURITY.md" as well.

Something like https://github.com/standard/.github/blob/master/SECURITY.md

And https://github.com/coredns/coredns/blob/master/.github/SECURITY.md

@sighingnow
Copy link
Member

@codecov-io
Copy link

codecov-io commented Jan 14, 2021

Codecov Report

Merging #144 (9df5cf8) into main (1ceb4ad) will decrease coverage by 12.53%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #144       +/-   ##
===========================================
- Coverage   76.33%   63.80%   -12.54%     
===========================================
  Files          53       53               
  Lines        3863     3884       +21     
===========================================
- Hits         2949     2478      -471     
- Misses        914     1406      +492     
Impacted Files Coverage Δ
src/server/services/meta_service.cc 29.76% <0.00%> (-50.97%) ⬇️
src/server/server/vineyard_server.h 60.00% <0.00%> (-40.00%) ⬇️
src/server/server/vineyard_server.cc 41.75% <0.00%> (-32.89%) ⬇️
src/server/services/meta_service.h 47.07% <0.00%> (-28.52%) ⬇️
src/server/async/socket_server.cc 64.68% <0.00%> (-16.50%) ⬇️
src/server/memory/stream_store.cc 49.56% <0.00%> (-16.23%) ⬇️
src/server/util/meta_tree.cc 60.65% <0.00%> (-15.88%) ⬇️
src/common/util/protocols.cc 77.41% <0.00%> (-14.05%) ⬇️
src/server/util/etcd_launcher.cc 64.76% <0.00%> (-13.12%) ⬇️
src/server/services/etcd_meta_service.h 80.00% <0.00%> (-12.00%) ⬇️
... and 3 more

@sighingnow sighingnow requested a review from wenyuanyu January 14, 2021 09:33
@sighingnow sighingnow merged commit 329360d into v6d-io:main Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants