Implement vineyardctl put command #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v6d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sighingnow
approved these changes
Sep 5, 2023
dashanji
reviewed
Sep 5, 2023
k8s/cmd/README.md
Outdated
Comment on lines
2165
to
2167
| er (default "vineyard-system") | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Please check the generated doc manually.
zhuyi1159
force-pushed
the
put_command
branch
from
521451d to
a25bfb9
Compare
Signed-off-by: zhuyi1159 <1159751291@qq.com>
Signed-off-by: zhuyi1159 <1159751291@qq.com>
Signed-off-by: zhuyi1159 <1159751291@qq.com>
Signed-off-by: zhuyi1159 <1159751291@qq.com>
dashanji
reviewed
Sep 7, 2023
k8s/cmd/commands/client/put.go
Outdated
| value := []byte(flags.Value) | ||
| object_id, err := client.PutBlob(value, uint64(len(flags.Value))) | ||
| if err != nil { | ||
| log.Printf("failed to put value: %s", err) |
There was a problem hiding this comment.
Suggested change
| log.Printf("failed to put value: %s", err) | |
| log.Errorf(err, fmt.Sprintf("failed to put value: %v", value)) |
dashanji
reviewed
Sep 7, 2023
k8s/cmd/commands/client/put.go
Outdated
Comment on lines
65
to
66
| objectId := fmt.Sprintf("o%016x", object_id) | ||
| fmt.Println("object id : ", objectId) |
There was a problem hiding this comment.
Suggested change
| objectId := fmt.Sprintf("o%016x", object_id) | |
| fmt.Println("object id : ", objectId) | |
| log.Output("object id : ", types.ObjectIDToString(object_id)) |
Signed-off-by: zhuyi1159 <1159751291@qq.com>
zhuyi1159
force-pushed
the
put_command
branch
from
a25bfb9 to
f1df854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
as titled
Related issue number
Fixes #1469