clean the unused code and prune vineyardctl dependency #1562
Conversation
✅ Deploy Preview for v6d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Hi @zhuyi1159 Using testify in _test.go modules should be fine.
|
But |
|
@zhuyi1159 Agree to reserve the testify, could you please update the following code from the ginkgo framework to the testify framework? Only reserving one test framework is fine. Also, please update the relevant file name as the test file will be rewritten while adding a new CRD. v6d/k8s/controllers/k8s/suite_test.go Lines 19 to 20 in dc61d92 v6d/k8s/apis/k8s/v1alpha1/webhook_suite_test.go Lines 24 to 25 in dc61d92 |
|
@zhuyi1159 Have you tested the |
|
Not tested locally. |
| } | ||
|
|
||
| var _ = BeforeSuite(func() { | ||
| func Test_BeforeSuite(t *testing.T) { |
There was a problem hiding this comment.
I think you'd better to under how the ginkgo framework works. BeforeSuite is used to build the environment for the test suit, you can't update it as a single test function. Also, please check the other similar parts.
|
|
||
| var _ = AfterSuite(func() { | ||
| func Test_AfterSuite(t *testing.T) { |
Could you please add the relevant unit test on CI or test locally? Thank you. |
|
@zhuyi1159 Please update to Paths: []string{filepath.Join("..", "..", "..", "config", "webhook","manifests.yaml")}, |
|
Also, please make sure the version of |
Signed-off-by: zhuyi1159 <1159751291@qq.com>
Signed-off-by: zhuyi1159 <1159751291@qq.com>
Signed-off-by: zhuyi1159 <1159751291@qq.com>
Signed-off-by: zhuyi1159 <1159751291@qq.com>
Signed-off-by: zhuyi1159 <1159751291@qq.com>
zhuyi1159
force-pushed
the
prune_vineyardctl
branch
from
2763405 to
f444894
Compare
Signed-off-by: zhuyi1159 <1159751291@qq.com>
|
Local tests passed. |
Signed-off-by: zhuyi1159 <1159751291@qq.com>
What do these changes do?
as titled
Related issue number
Fixes #1268