Support incremental loading data for 'vineyard-graph-loader' #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v6d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SighingSnow
force-pushed
the
sty/progress
branch
2 times, most recently
from
e103c02 to
bc6471d
Compare
siyuan0322
reviewed
Sep 16, 2023
|
And remember to use clang-format to format your codes before pushing, you could find the way to use it in the CI yamls. |
sighingnow
approved these changes
Sep 18, 2023
SighingSnow
force-pushed
the
sty/progress
branch
2 times, most recently
from
f47c218 to
0acbcb4
Compare
siyuan0322
approved these changes
Sep 25, 2023
| @@ -13,6 +13,7 @@ See the License for the specific language governing permissions and | |||
| limitations under the License. | |||
| */ | |||
|
|
|||
| #include <_types/_uint32_t.h> | |||
There was a problem hiding this comment.
Suggested change
| #include <_types/_uint32_t.h> |
| @@ -13,6 +13,7 @@ See the License for the specific language governing permissions and | |||
| limitations under the License. | |||
| */ | |||
|
|
|||
| #include <_types/_uint64_t.h> | |||
There was a problem hiding this comment.
Why not delete these headers?
sighingnow
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
LGTM. @SighingSnow could you please revert the etcd-cpp-apiv3 submodule changes?
Signed-off-by: SighingSnow <1263750383@qq.com>
SighingSnow
force-pushed
the
sty/progress
branch
3 times, most recently
from
05821c5 to
7559a79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add support for incremental vertices and edges for vineyard-graph-loader.
For step_by_step, the expected behaviors are as below
For whole or the default way, the expected behaviors are as below,
Related issue number
FIXES #1295
@siyuan0322 would you mind helping me review of the code