forked from nodejs/node
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip tests asserting an exact error message #142
Merged
lutzvahl
merged 1 commit into
v8:node-ci-2022-06-14
from
marjakh:fix-unexpected-identifier-error-message-skip
Jul 5, 2022
Merged
Skip tests asserting an exact error message #142
lutzvahl
merged 1 commit into
v8:node-ci-2022-06-14
from
marjakh:fix-unexpected-identifier-error-message-skip
Jul 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutzvahl
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamping based on marja@ request.
pthier
pushed a commit
that referenced
this pull request
Jul 20, 2022
Merging based on marja@ request.
victorgomes
pushed a commit
that referenced
this pull request
Aug 11, 2022
Merging based on marja@ request.
pthier
pushed a commit
that referenced
this pull request
Sep 22, 2022
Merging based on marja@ request.
victorgomes
pushed a commit
that referenced
this pull request
Oct 21, 2022
Merging based on marja@ request.
pthier
pushed a commit
that referenced
this pull request
Nov 16, 2022
Merging based on marja@ request.
pthier
pushed a commit
that referenced
this pull request
Feb 6, 2023
Merging based on marja@ request.
victorgomes
pushed a commit
that referenced
this pull request
Mar 16, 2023
Merging based on marja@ request.
pthier
pushed a commit
that referenced
this pull request
Apr 26, 2023
Merging based on marja@ request.
victorgomes
added a commit
that referenced
this pull request
May 22, 2023
Merging based on marja@ request. # Conflicts: # test/parallel/parallel.status
pthier
pushed a commit
that referenced
this pull request
Jul 4, 2023
Merging based on marja@ request.
pthier
pushed a commit
that referenced
this pull request
Aug 24, 2023
Merging based on marja@ request.
victorgomes
added a commit
that referenced
this pull request
Sep 12, 2023
Merging based on marja@ request.
victorgomes
added a commit
that referenced
this pull request
Sep 12, 2023
Merging based on marja@ request.
victorgomes
added a commit
that referenced
this pull request
Nov 8, 2023
Merging based on marja@ request.
pthier
pushed a commit
that referenced
this pull request
Jan 17, 2024
Merging based on marja@ request.
victorgomes
added a commit
that referenced
this pull request
Feb 14, 2024
Merging based on marja@ request.
victorgomes
added a commit
that referenced
this pull request
Mar 4, 2024
Merging based on marja@ request.
pthier
pushed a commit
that referenced
this pull request
Mar 21, 2024
Merging based on marja@ request.
victorgomes
added a commit
that referenced
this pull request
Apr 23, 2024
Merging based on marja@ request.
victorgomes
added a commit
that referenced
this pull request
Jun 3, 2024
Merging based on marja@ request.
pthier
pushed a commit
that referenced
this pull request
Jul 15, 2024
Merging based on marja@ request.
victorgomes
added a commit
that referenced
this pull request
Aug 22, 2024
Merging based on marja@ request.
pthier
pushed a commit
that referenced
this pull request
Oct 2, 2024
Merging based on marja@ request.
victorgomes
added a commit
that referenced
this pull request
Nov 18, 2024
Merging based on marja@ request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.