-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use of deprecated type v8::FastApiTypedArray #197
Remove use of deprecated type v8::FastApiTypedArray #197
Conversation
@gahaas we have been benchmarking alternatives to Refs: nodejs#54103 |
@ronag What exactly did you measure? If I remember correctly, the performance regression of removing |
memmove 64 bytes. |
Pleas see the references |
Thank you for making me aware of this issue. Could you please file a bug in the V8 bug tracker. Please add information on how I can reproduce the issue locally. Does node compile with PGO and LTO? I could imagine that the issue is that some API function calls get inlined in Chrome but not in node, as that would explain the different performance behavior. |
@targos Do you know someone that can answer this? |
# Conflicts: # src/crypto/crypto_timing.cc # src/node_buffer.cc # src/node_external_reference.h
In the examples where
v8::FastApiTypedArray
was used, there is actually no advantage of using V8's fast API calls instead of regular API calls. Therefore this CL just removes the fast API call targets instead of adjusting them.