Fix ninja build on Windows & --build-v8-with-gn improvements #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Fixes: * Fixed several hardcoded paths to use <(STATIC_LIB_PREFIX) & <(STATIC_LIB_SUFFIX) * Added GENERATOR=='ninja' conditionals to /WHOLEARCHIVE flags (msbuild puts .lib files under separate directories). * Add missing link_settings for v8_monolith * Set use_sysroot=false only for non-windows builds. Other improvements: * Split gn gen step from ninja step for --build-v8-with-gn * Add use_goma=true GN arg when --build-v8-with-gn-use-goma is passed To build using clang-cl: set CC="%cd%\deps\v8\third_party\llvm-build\Release+Asserts\bin\clang-cl.exe" python configure --build-v8-with-gn
|
The build instructions are However, |
5 tasks
|
The build also works with msvc, so we wouldn't want to set it unconditionally. Maybe add a |
|
Yup that makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.