Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placeholder tweet number #715

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Fix placeholder tweet number #715

merged 2 commits into from
Nov 2, 2023

Conversation

kripken
Copy link
Contributor

@kripken kripken commented Nov 2, 2023

The placeholder is an invalid link atm.

If/when we tweet this from the V8 Twitter account we can update this.

@kripken
Copy link
Contributor Author

kripken commented Nov 2, 2023

PTAL @ajklein

@kripken
Copy link
Contributor Author

kripken commented Nov 2, 2023

Updated to link to the tweet that was just published.

@kripken kripken changed the title Remove placeholder tweet number Fix placeholder tweet number Nov 2, 2023
Copy link
Member

@Liedtke Liedtke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kripken
Copy link
Contributor Author

kripken commented Nov 2, 2023

Not sure what went wrong in the CLA CI ("internal error"?), but as you can see it worked fine in the PR that just landed earlier: #714

@dtig dtig merged commit f541a2c into v8:main Nov 2, 2023
2 checks passed
@kripken kripken deleted the fix.twitter branch November 2, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants