Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix garbage collection problem #388

Merged
merged 2 commits into from
May 13, 2021
Merged

fix garbage collection problem #388

merged 2 commits into from
May 13, 2021

Conversation

v923z
Copy link
Owner

@v923z v923z commented May 13, 2021

This PR should close #387

jepler
jepler approved these changes May 13, 2021
View reviewed changes
Copy link
Collaborator

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it wouldn't hurt if my script was adapted into a test program, but otherwise if it fixes the problem for you I think it's good to go. I didn't do any testing.

@v923z
Copy link
Owner Author

v923z commented May 13, 2021

it wouldn't hurt if my script was adapted into a test program

Right. I will see to it. Thanks!

@v923z v923z merged commit 05e2c57 into master May 13, 2021
@v923z v923z deleted the gc-fix branch May 13, 2021 20:12
@v923z v923z mentioned this pull request May 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] ulab array corruption with slices
2 participants
@v923z @jepler