-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keepdims keyword argument #701
Conversation
@kwagyeman I think this should address the issue that you raised. I'll re-work this in the coming days, for the simple reason that others have requested the |
Awesome! Once this is merged we can integrate it into OpenMV. |
If this is urgent for you, I can merge this right away. I really see no reason for waiting otherwise. |
It's not urgent. Please test and build whatever confidence you need in the PR along with adding the other feature. |
@v923z - Any updates? Back to work now and would like to get this merged. |
I can merge the current implementation right away. I have the skeleton of the improved version, but I can't promise at the moment that I can flesh out all detail this weekend. So, if this is urgent, I would propose that we merge what we have now, and future improvements won't affect the user, for the interface will remain the same. |
I would emphasize that this is a correctly working implementation. |
That sounds good. That would unblock me after you release what you have. |
@kwagyeman I merged this before realising that I hadn't yet updated the documentation. Can you do the checkout against the commit, or do you need a release tag? I'll try to fix the docs tonight, though, I'm a bit booked out for today. I would release this only with the correct documentation. |
I can wait for that to be updated. |
OK. I can definitely fix that over the weekend. |
Add requested keyword argument keepdims to some numerical functions