Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter parameters 2 #7

Merged
merged 4 commits into from
Mar 4, 2015
Merged

Filter parameters 2 #7

merged 4 commits into from
Mar 4, 2015

Conversation

anagpuyol
Copy link
Contributor

@jeremytammik I have cloned gh-pages again and committed changes. This should work now. Please, let me know if you have any comments. Thanks! Ana

jeremytammik pushed a commit that referenced this pull request Mar 4, 2015
merged anagpuyol UI to filter parameters. Only selected parameters will be included in the JSON file. cf. original pull request #6, #6
@jeremytammik jeremytammik merged commit 15ac8b4 into va3c:gh-pages Mar 4, 2015
@jeremytammik jeremytammik mentioned this pull request Mar 4, 2015
@jeremytammik
Copy link
Contributor

i cleaned up and integrated your changes and published a new release 2015.0.0.30 to mark this memorable event :-) thank you! -- https://github.com/va3c/RvtVa3c/releases/tag/2015.0.0.30

@anagpuyol
Copy link
Contributor Author

great, thanks @jeremytammik

@anagpuyol anagpuyol deleted the Filter2 branch March 30, 2015 20:12
@jeremytammik
Copy link
Contributor

hi ana, i cleaned up a bit after your addition... you introduced quite a number of global variables that were not really needed... can you please check out the new version and ensure i did not break anything? thank you!

salaros pushed a commit to CodeCavePro/RvtVa3cExporter that referenced this pull request Sep 29, 2017
Sorry for the false alarm @anagpuyol 🚒
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants