Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server to resend a response message that client waits for #20506

Open
mshabarov opened this issue Nov 19, 2024 · 0 comments · May be fixed by #20547
Open

Server to resend a response message that client waits for #20506

mshabarov opened this issue Nov 19, 2024 · 0 comments · May be fixed by #20547
Assignees
@caalador
Labels
enhancement resynchronisation

Comments

@mshabarov
Copy link
Contributor

When server receives the same message id and hash as latest handled server should resend the previous payload to the client.

  • Store the latest handled payload until next id is handled
  • Only resend payload if client id & hash is the latest handled message

This should help to avoid unnecessary resynchronisations and loggings like:

com.vaadin.flow.server.communication.ServerRpcHandler   | Ignoring old duplicate message from the client. Expected: 1748, got: 1747.
@mshabarov mshabarov converted this from a draft issue Nov 19, 2024
@mshabarov mshabarov moved this from 📥Inbox - needs triage to 🪵Product backlog in Vaadin Flow ongoing work (Vaadin 10+) Nov 19, 2024
@mshabarov mshabarov mentioned this issue Nov 19, 2024
Closed
3 tasks
@caalador caalador self-assigned this Nov 21, 2024
@caalador caalador moved this from 🟢Ready to Go to ⚒️ In progress in Vaadin Flow ongoing work (Vaadin 10+) Nov 21, 2024
caalador added a commit that referenced this issue Nov 25, 2024
@caalador
feat: resend payload of reoccuring client request
09fd5d5 
If the client request contains
the previous id and exactly the
same message content respond with
the same payload as previously.

Closes #20506
@caalador caalador linked a pull request Nov 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caalador caalador

Labels
enhancement resynchronisation
Projects
Vaadin Flow ongoing work (Vaadin 10+)
Status: 🔎Iteration reviews
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: resend payload of reoccuring client request vaadin/flow
2 participants
@caalador @mshabarov