Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resend payload of reoccuring client request #20547

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

caalador
Copy link
Contributor

If the client request contains
the previous id and exactly the
same message content respond with
the same payload as previously.

Closes #20506

If the client request contains
the previous id and exactly the
same message content respond with
the same payload as previously.

Closes #20506
Copy link

github-actions bot commented Nov 25, 2024

Test Results

1 158 files  ± 0  1 158 suites  ±0   1h 38m 3s ⏱️ + 6m 25s
7 514 tests + 1  7 461 ✅ + 1  53 💤 ±0  0 ❌ ±0 
7 892 runs  +65  7 829 ✅ +65  63 💤 ±0  0 ❌ ±0 

Results for commit 5be342a. ± Comparison against base commit 3149de8.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
com.vaadin.flow.server.communication.ServerRpcHandlerTest ‑ handleRpc_duplicateMessage_doNotThrow
com.vaadin.flow.server.communication.ServerRpcHandlerTest ‑ handleRpc_duplicateMessage_throwsResendPayload
com.vaadin.flow.server.communication.UidlRequestHandlerTest ‑ clientRequestsPreviousIdAndPayload_resendPreviousResponse

♻️ This comment has been updated with latest results.

@mcollovati
Copy link
Collaborator

Tested with a custom buggy UIDLRequestHandler that seldom drops a response, returning a 410 response code.
The change proved to work very well. When a response for an UIDL message does not reach the client, then the connection status indicator appears for a moment, but then when the request is re-sent, the client receives the correct response and all proceeds correctly.

Copy link

sonarcloud bot commented Nov 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server to resend a response message that client waits for
4 participants