chore: skip service worker plugin for non PWAs #10361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haijian-vaadin
force-pushed
the
haijian/frontend-build-optimization
branch
from
1480105 to
c826076
Compare
haijian-vaadin
force-pushed
the
haijian/frontend-build-optimization
branch
from
c826076 to
39f24f7
Compare
haijian-vaadin
changed the title
joheriks
suggested changes
Mar 22, 2021
haijian-vaadin
force-pushed
the
haijian/frontend-build-optimization
branch
from
39f24f7 to
03332bc
Compare
joheriks
previously approved these changes
Mar 22, 2021
haijian-vaadin
force-pushed
the
haijian/frontend-build-optimization
branch
from
03332bc to
8f93bde
Compare
joheriks
approved these changes
Mar 24, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 24, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce frontend build time for non-PWA applications by not running the service worker Webpack plugin.