Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hilla): make tsconfig.json React compatible #15084

Merged
merged 11 commits into from
Nov 29, 2022
Merged

feat(hilla): make tsconfig.json React compatible #15084

merged 11 commits into from
Nov 29, 2022

Conversation

platosha
Copy link
Contributor

@platosha platosha commented Nov 10, 2022 •
edited
Loading

Summary of changes:

  • Added a good default for jsx setting
  • Relaxed file extensions for TypeScript, so that .tsx and such are considered

This should not interfere with existing TypeScript / Lit-based code.

@github-actions
Copy link

github-actions bot commented Nov 10, 2022 •
edited
Loading

Unit Test Results

   564 files   - 394     564 suites   - 394   41m 5s ⏱️ - 15m 11s
5 588 tests  - 523  5 563 ✔️  - 494  25 💤  - 29  0 ❌ ±0 
5 600 runs   - 775  5 575 ✔️  - 738  25 💤  - 37  0 ❌ ±0 

Results for commit 0b85ccb. ± Comparison against base commit 4a45c71.

♻️ This comment has been updated with latest results.

Artur-
Artur- reviewed Nov 10, 2022
View reviewed changes
Copy link
Member

@Artur- Artur- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify the changes so we know in the future why they were made

flow-server/src/main/resources/com/vaadin/flow/server/frontend/tsconfig.json Outdated Show resolved Hide resolved
flow-server/src/main/resources/com/vaadin/flow/server/frontend/tsconfig.json Show resolved Hide resolved
flow-server/src/main/resources/com/vaadin/flow/server/frontend/tsconfig.json Outdated Show resolved Hide resolved
flow-server/src/main/resources/com/vaadin/flow/server/frontend/tsconfig.json Outdated Show resolved Hide resolved
flow-server/src/main/resources/com/vaadin/flow/server/frontend/tsconfig.json Show resolved Hide resolved
@platosha platosha force-pushed the feat/react-tsconfig branch from 0b85ccb to 4195fa9 Compare November 28, 2022 13:00
@platosha platosha requested a review from Artur- November 28, 2022 13:05
@github-actions
Copy link

github-actions bot commented Nov 28, 2022 •
edited
Loading

Test Results

   939 files  ±  0     939 suites  ±0   58m 37s ⏱️ + 2m 16s
5 932 tests ±  0  5 886 ✔️ ±  0  46 💤 ±0  0 ❌ ±0 
6 194 runs  +11  6 141 ✔️ +11  53 💤 ±0  0 ❌ ±0 

Results for commit c97d852. ± Comparison against base commit 719a3dd.

♻️ This comment has been updated with latest results.

Artur-
Artur- reviewed Nov 28, 2022
View reviewed changes
flow-server/src/main/resources/com/vaadin/flow/server/frontend/tsconfig.json Outdated
@@ -7,6 +7,7 @@
"flow_version": "23.3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated

Artur-
Artur- requested changes Nov 28, 2022
View reviewed changes
Copy link
Member

@Artur- Artur- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version needs to be updated, right @mshabarov ?

@mshabarov
Copy link
Contributor

@Artur- @platosha yes, we should update some parts to make autoupdate works fine:

  1. Increment version in tsconfig.json ("flow_version" property): can be "flow_version" : "23.3.1".
  2. Create a new tsconfig-v23.3.0.json template in flow-server resources and put the old content there (before your patch)
  3. Update vaadinVersion array in TaskGenerateTsConfig with v23.3.0
  4. Put a new content in tsconfig-reference.json in tests.

P.S. yes, I know this manual work looks ugly...maybe I can remove (2) - (4) someday.

@platosha
Copy link
Contributor Author

@Artur- @mshabarov OK done, even though 23.3.0 was not even released yet...

@platosha
Copy link
Contributor Author

Whoa, a test failed.

@mshabarov FYI the instructions were missing a step: 9af2f3c

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@platosha platosha merged commit 448ed9b into master Nov 29, 2022
@platosha platosha deleted the feat/react-tsconfig branch November 29, 2022 15:21
vaadin-bot pushed a commit that referenced this pull request Nov 29, 2022
@platosha @vaadin-bot
feat(hilla): make tsconfig.json React compatible (#15084)
43996a5 
* feat(hilla): make tsconfig.json React compatible

* chore: update tsconfig-reference.json

* chore: update tsconfig version

* test: update tsconfig latest version and instructions

* chore: set tsconfig flow_version to 23.3.0.1
vaadin-bot added a commit that referenced this pull request Nov 29, 2022
@vaadin-bot @platosha
feat(hilla): make tsconfig.json React compatible (#15084) (#15312)
603b685 
* feat(hilla): make tsconfig.json React compatible

* chore: update tsconfig-reference.json

* chore: update tsconfig version

* test: update tsconfig latest version and instructions

* chore: set tsconfig flow_version to 23.3.0.1

Co-authored-by: Anton Platonov <anton@vaadin.com>
MarcinVaadin pushed a commit that referenced this pull request Dec 21, 2022
@platosha @MarcinVaadin
feat(hilla): make tsconfig.json React compatible (#15084)
5c227ae 
* feat(hilla): make tsconfig.json React compatible

* chore: update tsconfig-reference.json

* chore: update tsconfig version

* test: update tsconfig latest version and instructions

* chore: set tsconfig flow_version to 23.3.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lodin Lodin Lodin left review comments

@mshabarov mshabarov mshabarov approved these changes

@Artur- Artur- Artur- approved these changes

Assignees
No one assigned
Labels
cherry-picked-23.3 hilla Issues related to Hilla react target/23.3 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@platosha @mshabarov @Artur- @Lodin @vaadin-bot