fix: Use feature detection to show the unsupported browser page #15813
Conversation
| + "';window.location.reload();return false;\" href=\"#\">Continue without updating</a> (not recommended)</sub></p>" | ||
| + "</body>\n" + "</html>"); | ||
| // @formatter:on | ||
| IOUtils.copy(getClass().getResourceAsStream("too-old.html"), page, |
There was a problem hiding this comment.
Would it make sense to allow people to customize this?
There was a problem hiding this comment.
You mean in a less fragile way than adding your own src/main/resources/com/vaadin/flow/server/too-old.html ?
There was a problem hiding this comment.
If you say it like this: yes 😅
There was a problem hiding this comment.
Ok now you can use src/main/resources/browser-too-old.html instead :)
There was a problem hiding this comment.
Thanks 🙇♂️ This is great! Having a way to customize this page is really good. We had requests in the past especially for translation and corporate styling needs. Could be something worth to mention as new feature for v24 - some people are really looking forward to it. Customizing it atm is just hacky
|
Note that if this is backported (it probably should be) then the feature set to detect is different (ResizeObserver should be ok) |
Artur-
force-pushed
the
too-old-features
branch
from
6667838 to
228d443
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Yes, we could mention that even though usage is likely below 0.1% |
| if (!('CSSLayerBlockRule' in window)) { | ||
| window.location.search='v-r=oldbrowser'; | ||
| } | ||
| """); |
There was a problem hiding this comment.
So is it a place where we put the checks for used features?
) This removes the `WebBrowser. isTooOldToFunctionProperly()` method as it is no longer possible to determine this information based on the user agent. Fixes #14366
) (CP: 23.3) Changed to detect ResizeObserver This removes the `WebBrowser. isTooOldToFunctionProperly()` method as it is no longer possible to determine this information based on the user agent. Fixes #14366
) (CP: 23.3) Changed to detect ResizeObserver This removes the `WebBrowser. isTooOldToFunctionProperly()` method as it is no longer possible to determine this information based on the user agent. Fixes #14366
) (CP: 23.3) (#16024) Changed to detect ResizeObserver This removes the `WebBrowser. isTooOldToFunctionProperly()` method as it is no longer possible to determine this information based on the user agent. Fixes #14366 Co-authored-by: czp13 <61667986+czp13@users.noreply.github.com> Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Fixes #14366