Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resume client to server communication after web socket reconnection #20283

Merged
merged 3 commits into from
Nov 7, 2024

Commits on Oct 18, 2024

  1. fix: resume client to server communication after web socket reconnection

    When a websocket PUSH connection is closed and re-established because
    of a network failure, the RequestResponseTracker.hasActiveRequest is
    not reset, prenvint the Flow client to send additional messages to
    the server.
    This change will reset the flag on reconnection. It also will track
    unsent PUSH message over websocket, to retry the delivery once the
    connection is re-established, preventing client resynchronization.
    In addition, it sets a default value of 12 for the Atmospehere
    maxWebsocketErrorRetries setting, to ensure that the Flow client will
    attempt to reconnect with web socket transport several times, instead
    of immediately downgrade to long-polling after first failed connection.
    
    Fixes #20213
    mcollovati committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5a93895 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Configuration menu
    Copy the full SHA
    a804f85 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Configuration menu
    Copy the full SHA
    c39d00a View commit details
    Browse the repository at this point in the history