fix: compute unique key for artifact

[mcollovati]

Computes a unique key for maven artifacts when collecting dependencies for the Flow maven plugin isolated classloader.

fixes #20555

[github-actions]

Test Results

1 158 files  ± 0  1 158 suites  ±0   1h 39m 43s ⏱️ + 8m 7s
7 514 tests ± 0  7 461 ✅ ± 0  53 💤 ±0  0 ❌ ±0 
7 874 runs  +12  7 812 ✅ +12  62 💤 ±0  0 ❌ ±0 

Results for commit e889a11. ± Comparison against base commit 9c1e56c.

♻️ This comment has been updated with latest results.

[sonarqubecloud]

Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[mshabarov]

This patch should fix the reported issue, LGTM.

Just a question: should we also add version and scope to the artifact's key mapper?
I don't know the whole context of this feature, maybe the version is handled already in some other place.

[mcollovati]

Just a question: should we also add version and scope to the artifact's key mapper?

Key mapper is used to identify artifacts that are defined as dependencies for both project and Flow maven plugin. If there are duplicates, we choose the project dependency.
So, version and scope should not be considered; otherwise we will not be able to detect duplicates.
And in the same project, it is an error to define the same dependency twice with a different version or a different scope.

Also, Maven DefaultArtifact.getId() does not consider scope. It is composed by concatenating getDependencyConflictId() with getBaseVersion(), and getDependencyConflictId() is basically groupId:artifactId:type[:classifier]