Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change internals to use Jackson #20962

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Feb 7, 2025

Change part of the internal methods
to use Jackson instead of Elemental Json.

Public methods marked deprecated as
far as plausible.

part of #20741

@caalador caalador force-pushed the issues/20741-internal-use-of-json-to-jackson branch 3 times, most recently from 0e1963e to 05bd453 Compare February 7, 2025 09:01
Copy link

github-actions bot commented Feb 7, 2025

Test Results

  553 files   -   612    553 suites   - 612   12m 1s ⏱️ - 1h 23m 48s
6 579 tests  - 1 060  6 562 ✅  - 1 020  17 💤  - 40  0 ❌ ±0 
6 590 runs   - 1 377  6 573 ✅  - 1 330  17 💤  - 47  0 ❌ ±0 

Results for commit 99a422a. ± Comparison against base commit 714d220.

This pull request removes 1098 and adds 38 tests. Note that renamed tests count towards both.
com.vaadin.flow.AddQueryParamIT ‑ validateReactInUse[any_Chrome_]
com.vaadin.flow.AddQueryParamIT(production) ‑ validateReactInUse[any_Chrome_]
com.vaadin.flow.AssertionTest ‑ testAssertionsAreEnabled
com.vaadin.flow.BackNavIT ‑ backButtonWorksAndContentUpdatesAfterPageRefresh[any_Chrome_]
com.vaadin.flow.BackNavIT ‑ testBackButtonAfterHistoryStateChange[any_Chrome_]
com.vaadin.flow.BackNavIT ‑ validateNoAfterNavigationForReplaceState[any_Chrome_]
com.vaadin.flow.BackNavIT(production) ‑ backButtonWorksAndContentUpdatesAfterPageRefresh[any_Chrome_]
com.vaadin.flow.BackNavIT(production) ‑ testBackButtonAfterHistoryStateChange[any_Chrome_]
com.vaadin.flow.BackNavIT(production) ‑ validateNoAfterNavigationForReplaceState[any_Chrome_]
com.vaadin.flow.ClientResourceIT ‑ clientResourcesAreNotExposed[any_Chrome_]
…
com.vaadin.flow.component.polymertemplate.rpc.PolymerPublishedEventRpcHandlerTest ‑ templateWithModel_faultyPayloadAsNoObjectNode_returnsFalse
com.vaadin.flow.dom.ElementTest ‑ getJacksonPropertyStringConversions
com.vaadin.flow.dom.ElementTest ‑ listenerReceivesEventsJackson
com.vaadin.flow.dom.ElementTest ‑ listenerReceivesEventsWithAllowInertJackson
com.vaadin.flow.dom.ElementTest ‑ testJacksonPropertyBooleanConversions
com.vaadin.flow.internal.JacksonCodecTest ‑ decodeAs_booleanJson
com.vaadin.flow.internal.JacksonCodecTest ‑ decodeAs_jsonValue
com.vaadin.flow.internal.JacksonCodecTest ‑ decodeAs_jsonValueWrongType_classCastException
com.vaadin.flow.internal.JacksonCodecTest ‑ decodeAs_nullJson
com.vaadin.flow.internal.JacksonCodecTest ‑ decodeAs_numberJson
…

♻️ This comment has been updated with latest results.

@caalador caalador force-pushed the issues/20741-internal-use-of-json-to-jackson branch from 05bd453 to 1f93afc Compare February 7, 2025 09:40
@vaadin-bot
Copy link
Collaborator

vaadin-bot commented Feb 7, 2025

TC Format Checker Report - 10:21 - 07 - Feb

BLOCKER There are 7 files with format errors

  • To see a complete report of formatting issues, download the differences file

  • To fix the build, please run mvn formatter:format in your branch and commit the changes.

  • Optionally you might add the following line in your .git/hooks/pre-commit file:

    mvn formatter:format
    

Here is the list of files with format issues in your PR:

flow-server/src/main/java/com/vaadin/flow/router/internal/AbstractNavigationStateRenderer.java
flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/BasicElementView.java
flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/DebounceSynchronizePropertyView.java
flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/DomEventFilterView.java
flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/FragmentLinkView.java
flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/RouterLinkView.java
flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/scroll/PushStateScrollView.java

Change part of the internal methods
to use Jackson instead of Elemental Json.

Public methods marked deprecated as
far as plausible.

part of #20741
@caalador caalador force-pushed the issues/20741-internal-use-of-json-to-jackson branch from 1f93afc to 99a422a Compare February 7, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants