Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Hilla packages always when Hilla is available in classpath #20963

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mshabarov
Copy link
Contributor

Adds Hilla packages always when Hilla is available in classpath, i.e. when not excluded manually.

Fixes #20959
Fixes vaadin/hilla#3211

Copy link

github-actions bot commented Feb 7, 2025

Test Results

  929 files   -   236    929 suites   - 236   1h 20m 2s ⏱️ - 16m 32s
5 057 tests  - 2 582  4 998 ✅  - 2 584  56 💤  - 1  2 ❌ +2  1 🔥 +1 
5 288 runs   - 2 646  5 227 ✅  - 2 643  58 💤  - 6  2 ❌ +2  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit dc17c21. ± Comparison against base commit feac410.

This pull request removes 2582 tests.
com.vaadin.base.devserver.AbstractDevServerRunnerTest ‑ shouldPassEncodedUrlToDevServer
com.vaadin.base.devserver.AbstractDevServerRunnerTest ‑ updateServerStartupEnvironment_preferIpv4_LocalhostIpAddressAddedToProcessEnvironment
com.vaadin.base.devserver.AbstractDevServerRunnerTest ‑ updateServerStartupEnvironment_preferIpv6_LocalhostIpAddressAddedToProcessEnvironment
com.vaadin.base.devserver.BrowserLiveReloadAccessorImplTest ‑ getLiveReload_devMode_contextHasNoReloadInstance_instanceIsCreated
com.vaadin.base.devserver.BrowserLiveReloadAccessorImplTest ‑ getLiveReload_devMode_contextHasReloadInstance_instanceIsReturned
com.vaadin.base.devserver.BrowserLiveReloadAccessorImplTest ‑ getLiveReload_liveReloadDisabled_instanceIsCreated
com.vaadin.base.devserver.BrowserLiveReloadAccessorImplTest ‑ getLiveReload_productionMode_nullIsReturned
com.vaadin.base.devserver.DebugWindowConnectionTest ‑ backwardsCompatibilityClassExists
com.vaadin.base.devserver.DebugWindowConnectionTest ‑ getBackend_HotSwapVaadinIntegrationClassLoaded_returnsHOTSWAP_AGENT
com.vaadin.base.devserver.DebugWindowConnectionTest ‑ getBackend_JRebelClassEventListenerClassLoaded_returnsJREBEL
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants