Call VaadinService::requestStart if push transport is websocket #7489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caalador
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
TatuLund
added a commit
to vaadin/framework
that referenced
this pull request
Feb 5, 2020
onConnect was allways called with websocket = false. I think this is wrong, since if there was connection loss in websocket, now connection cannot be re-established in websocket mode. Fixes: #11299 This bug may have been manifesting in other ways as well Recently similar fix was done in Flow as well, see: vaadin/flow#7489
pleku
pushed a commit
that referenced
this pull request
Feb 6, 2020
pleku
pushed a commit
that referenced
this pull request
Feb 6, 2020
pleku
pushed a commit
that referenced
this pull request
Feb 7, 2020
caalador
pushed a commit
that referenced
this pull request
Feb 7, 2020
Ansku
pushed a commit
to vaadin/framework
that referenced
this pull request
Apr 7, 2020
onConnect was allways called with websocket = false. I think this is wrong, since if there was connection loss in websocket, now connection cannot be re-established in websocket mode. Fixes: #11299 This bug may have been manifesting in other ways as well Recently similar fix was done in Flow as well, see: vaadin/flow#7489
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7116
This change is