Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store scroll position in state when entering route not found view (#8698) #8709

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Store scroll position in state when entering route not found view (#8698) #8709

merged 2 commits into from
Jul 14, 2020

Conversation

joheriks
Copy link
Contributor

@joheriks joheriks commented Jul 9, 2020 •
edited
Loading

Closes #8693. Disabled ITs as scroll position handling requires a separate fix for client-side router.

Johannes Eriksson added 2 commits July 9, 2020 10:49
Store scroll position in state when entering route not found view (#8698
8e9137a 
)

* Store scroll position in state when entering route not found view

* Removed unused method. Only throw for other events than ErrorNavigationEvent.

* Modified logic to only push state for route not found error
Disable IT when using client router
a90780f
@joheriks joheriks marked this pull request as ready for review July 10, 2020 06:39
@mshabarov mshabarov merged commit d73d67d into master Jul 14, 2020
@mshabarov mshabarov deleted the cp/8693-routerlink-scroll-position branch July 14, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshabarov mshabarov mshabarov approved these changes

Assignees
No one assigned
Labels
cherry pick +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scroll position not resetted for broken router links
3 participants
@joheriks @mshabarov @vaadin-bot