fix: Make it possible to add and remove shortcut listener in compatib… #12203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansku
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Ansku
pushed a commit
that referenced
this pull request
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ility TextField
There was regression due earlier bugfix #11871
Or more precisely the fix was not complete.
There was special handling of TextField and TextArea in Vaadin 7, which actually have functioning flush method in their connector
https://github.com/vaadin/framework/blob/7.7/client/src/main/java/com/vaadin/client/ui/ShortcutActionHandler.java#L161
This patch re-indroduces the special handling without of need of re-introducing BeforeShortcutActionListener mechanism.
This change is