fix: handle child layouts #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle child layouts depending on if they have flowLayout true or false. Fixes all layouts having flowLayout if the parent layout or one child has flowLayout true. Fixes #20261
caalador
force-pushed
the
issues/20261-differing-layouts
branch
from
a801123
to
e2d86cf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2853 +/- ##
==========================================
- Coverage 92.65% 92.63% -0.02%
==========================================
Files 83 83
Lines 2831 2839 +8
Branches 729 740 +11
==========================================
+ Hits 2623 2630 +7
- Misses 156 158 +2
+ Partials 52 51 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@platosha could you or someone else from Hilla team please review this pull request before we lost the memories what the topic was about 😄 |
Lodin
approved these changes
Nov 15, 2024
|
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
* fix: handle child layouts Handle child layouts depending on if they have flowLayout true or false. Fixes all layouts having flowLayout if the parent layout or one child has flowLayout true. Fixes #20261 * refactor(file-router): flowLayout subtree implementation cleanup --------- Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com> Co-authored-by: Anton Platonov <platosha@gmail.com>
platosha
added a commit
that referenced
this pull request
Nov 15, 2024
fix: handle child layouts (#2853) * fix: handle child layouts Handle child layouts depending on if they have flowLayout true or false. Fixes all layouts having flowLayout if the parent layout or one child has flowLayout true. Fixes #20261 * refactor(file-router): flowLayout subtree implementation cleanup --------- Co-authored-by: caalador <mgrankvi@vaadin.com> Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com> Co-authored-by: Anton Platonov <platosha@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle child layouts depending
on if they have flowLayout true or false.
Fixes all layouts having flowLayout
if the parent layout or one child has
flowLayout true.
Fixes vaadin/flow#20261