Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Opt-in React Router v7 features #2929

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Conversation

mshabarov
Copy link
Contributor

Preparations for React Router v7, opts-in the new features to avoid warnings in console.

Related-to vaadin/flow#20527

Preparations for React Router v7, opts-in the new features to avoid warnings in console.

Related-to vaadin/flow#20527
Lodin
Lodin previously approved these changes Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.79%. Comparing base (cd5eb37) to head (01811cf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2929   +/-   ##
=======================================
  Coverage   92.79%   92.79%           
=======================================
  Files          84       84           
  Lines        3149     3149           
  Branches      759      759           
=======================================
  Hits         2922     2922           
  Misses        175      175           
  Partials       52       52           
Flag Coverage Δ
unittests 92.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lodin Lodin enabled auto-merge (squash) November 27, 2024 14:32
@Lodin Lodin disabled auto-merge November 27, 2024 14:32
@Lodin Lodin enabled auto-merge (squash) November 27, 2024 14:55
Copy link

sonarcloud bot commented Nov 27, 2024

@Lodin Lodin merged commit 84f99a2 into main Nov 27, 2024
15 checks passed
@Lodin Lodin deleted the react-router-feature-flags branch November 27, 2024 15:05
cromoteca pushed a commit that referenced this pull request Nov 27, 2024
* chore: Opt-in React Router v7 features

Preparations for React Router v7, opts-in the new features to avoid warnings in console.

Related-to vaadin/flow#20527

* fix test

---------

Co-authored-by: Vlad Rindevich <vladrin@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants