Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: inform about blocking popups #70

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

MarcinVaadin
Copy link
Member

@MarcinVaadin MarcinVaadin commented Sep 5, 2024

Moves IDE window to front when potential blocking popup window would appear. Notifies Copilot when blocking popup is shown

requires https://github.com/vaadin/copilot-internal/pull/3005

@MarcinVaadin MarcinVaadin marked this pull request as ready for review September 6, 2024 08:49
@czp13
Copy link

czp13 commented Sep 6, 2024

Started to test.

I see two new notifications I have not seen, probably recent developments I did not test yet:
image

These are happening after I installed the plugin version shared here 🙇

Copy link

@czp13 czp13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed my comments to here:

The same applies here :)

Anyway the code seems good and the feature with a bit of tweaking could be handy, and helpful! Let the user know they need to accept, refresh, reload, close the blocking popup in Intellij, and not just wait in the browser.

@MarcinVaadin
Copy link
Member Author

I see two new notifications I have not seen, probably recent developments I did not test yet:

Yes, those are from previous PRs

@MarcinVaadin MarcinVaadin marked this pull request as draft September 6, 2024 11:01
@czp13
Copy link

czp13 commented Sep 6, 2024

Yes, those are from previous PRs
Thanks, good additions! :)

@MarcinVaadin MarcinVaadin force-pushed the chore/move-to-front-on-blocking-popup branch from 949b7e3 to 46ae61c Compare September 9, 2024 08:10
@MarcinVaadin MarcinVaadin marked this pull request as ready for review September 9, 2024 08:11
Copy link

github-actions bot commented Sep 9, 2024

Artifact build on last commit: distributions.zip.
For MacOS users: there is a zip inside this zip and Finder unzips them both at once. Use unzip distributions.zip from Terminal or check solution for Archive Manager.

@czp13
Copy link

czp13 commented Sep 9, 2024

As said here:

This works quite stable, but I cannot make it show the popup.

@MarcinVaadin MarcinVaadin merged commit d1e1982 into main Sep 10, 2024
3 checks passed
@MarcinVaadin MarcinVaadin deleted the chore/move-to-front-on-blocking-popup branch September 10, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants