-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: inform about blocking popups #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed my comments to here:
The same applies here :)
Anyway the code seems good and the feature with a bit of tweaking could be handy, and helpful! Let the user know they need to accept, refresh, reload, close the blocking popup in Intellij, and not just wait in the browser.
Yes, those are from previous PRs |
|
949b7e3
to
46ae61c
Compare
Artifact build on last commit: distributions.zip. |
As said here: This works quite stable, but I cannot make it show the popup. |
Moves IDE window to front when potential blocking popup window would appear. Notifies Copilot when blocking popup is shown
requires https://github.com/vaadin/copilot-internal/pull/3005