Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP: do not merge] switch from promises to async / await #191

Closed
wants to merge 1 commit into from
Closed

[WIP: do not merge] switch from promises to async / await #191

wants to merge 1 commit into from

Conversation

vlukashov
Copy link
Contributor

@vlukashov vlukashov commented Jun 20, 2018 •
edited
Loading

  • this helped to uncover a number of order-of-execution issues

This change is Reviewable

rewrite Router.render() using async and await
a225bd0 
 - this helped to uncover a number of order-of-execution issues
@vlukashov vlukashov changed the title ]rewrite Router.render() using async and await [WIP: do not merge] switch from promises to async / await Jun 20, 2018
@vlukashov vlukashov closed this Jun 26, 2018
@vlukashov vlukashov deleted the refactor/use-async branch June 26, 2018 07:51
@vlukashov vlukashov restored the refactor/use-async branch June 27, 2018 08:53
vlukashov pushed a commit that referenced this pull request Jan 29, 2021
fix failing tests after path-to-regexp 6.2.0 update
bb8b4d2 
- since `path-to-regexp` 3.1.0 the way of passing options into the `tokensToFunction()` function has changed (see [#191](pillarjs/path-to-regexp#191)).
- since `path-to-regexp` 4.0.0 the default exports have changed from a module object to individual functions (see [4.0.0](https://github.com/pillarjs/path-to-regexp/releases/tag/v4.0.0)).
- since `path-to-regexp` 5.0.0 the default value for the optional `encode` parameter in the `tokensToFunction()` function has changed (see [5.0.0](https://github.com/pillarjs/path-to-regexp/releases/tag/v5.0.0)).
- since `path-to-regexp` 6.0.0 the `repeat` and `modifier` properties on route regexp keys were removed (see [#207](pillarjs/path-to-regexp#207)).

The internals of the `@vaadin/router` package affected by these changes are updated so that the Vaadin Router public API remains unchanged.
vlukashov pushed a commit that referenced this pull request Jan 29, 2021
fix failing tests after path-to-regexp 6.2.0 update
cb6e2de 
- since `path-to-regexp` 3.1.0 the way of passing options into the `tokensToFunction()` function has changed (see [#191](pillarjs/path-to-regexp#191)).
- since `path-to-regexp` 4.0.0 the default exports have changed from a module object to individual functions (see [4.0.0](https://github.com/pillarjs/path-to-regexp/releases/tag/v4.0.0)).
- since `path-to-regexp` 5.0.0 the default value for the optional `encode` parameter in the `tokensToFunction()` function has changed (see [5.0.0](https://github.com/pillarjs/path-to-regexp/releases/tag/v5.0.0)).
- since `path-to-regexp` 6.0.0 the `repeat` and `modifier` properties on route regexp keys were removed (see [#207](pillarjs/path-to-regexp#207)).

The internals of the `@vaadin/router` package affected by these changes are updated so that the Vaadin Router public API remains unchanged.
haijian-vaadin pushed a commit that referenced this pull request Feb 1, 2021
fix failing tests after path-to-regexp 6.2.0 update (#549)
b081aa3 
* fix failing tests after path-to-regexp 6.2.0 update

- since `path-to-regexp` 3.1.0 the way of passing options into the `tokensToFunction()` function has changed (see [#191](pillarjs/path-to-regexp#191)).
- since `path-to-regexp` 4.0.0 the default exports have changed from a module object to individual functions (see [4.0.0](https://github.com/pillarjs/path-to-regexp/releases/tag/v4.0.0)).
- since `path-to-regexp` 5.0.0 the default value for the optional `encode` parameter in the `tokensToFunction()` function has changed (see [5.0.0](https://github.com/pillarjs/path-to-regexp/releases/tag/v5.0.0)).
- since `path-to-regexp` 6.0.0 the `repeat` and `modifier` properties on route regexp keys were removed (see [#207](pillarjs/path-to-regexp#207)).

The internals of the `@vaadin/router` package affected by these changes are updated so that the Vaadin Router public API remains unchanged.

* chore: fix linter errors - declare `xit` global

* fix: do not re-export pathToRegexp in the ES bundle

In the ES module bundle the users may as well just import path-to-regexp themselves.

In the UMD bundle, keep things 'as-is'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vlukashov