Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure search and hash in context, location, and lifecycle #396

Merged
merged 1 commit into from
Sep 30, 2019
Merged

fix: ensure search and hash in context, location, and lifecycle #396

merged 1 commit into from
Sep 30, 2019

Conversation

platosha
Copy link
Contributor

@platosha platosha commented Sep 24, 2019 •
edited
Loading

Connected to #56

This change is Reviewable

@platosha platosha added the hilla label Sep 24, 2019
@platosha platosha force-pushed the feat/query-string-params branch 2 times, most recently from 7eed772 to c8c96fa Compare September 26, 2019 12:52
@platosha platosha changed the title --wip-- feat: add search parameters to context and url helpers ensure search and hash in action context and component location Sep 26, 2019
@platosha platosha marked this pull request as ready for review September 26, 2019 12:53
platosha added a commit that referenced this pull request Sep 26, 2019
@platosha
docs: add demos for search and hash usage
e8f67e3 
Fixes #56

Depends on #396
@platosha platosha mentioned this pull request Sep 26, 2019
Merged
@platosha platosha force-pushed the feat/query-string-params branch from c8c96fa to 4ed65ca Compare September 27, 2019 10:43
@platosha platosha changed the title ensure search and hash in action context and component location fix: ensure search and hash in context, location, and lifecycle Sep 27, 2019
@platosha platosha force-pushed the feat/query-string-params branch from 4ed65ca to 1154d88 Compare September 27, 2019 12:51
qtdzz
qtdzz approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@qtdzz qtdzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@qtdzz qtdzz merged commit 5a37eb4 into master Sep 30, 2019
@qtdzz qtdzz deleted the feat/query-string-params branch September 30, 2019 06:36
platosha added a commit that referenced this pull request Sep 30, 2019
@platosha
docs: add demos for search and hash usage
1272a57 
Fixes #56

Depends on #396
manolo pushed a commit that referenced this pull request Oct 1, 2019
@platosha @manolo
docs: add demos for search and hash usage (#397)
9341511 
* docs: add demos for search and hash usage

Fixes #56

Depends on #396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qtdzz qtdzz qtdzz approved these changes

Assignees
No one assigned
Labels
hilla
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@platosha @qtdzz