Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative names for blacklisted-packages and whitelisted-packages #645

Closed
joheriks opened this issue Jul 22, 2020 · 3 comments · Fixed by #1077 or vaadin/flow#18405
Closed

Alternative names for blacklisted-packages and whitelisted-packages #645

joheriks opened this issue Jul 22, 2020 · 3 comments · Fixed by #1077 or vaadin/flow#18405
Labels
enhancement needs design Released with Vaadin 23.3.33

Comments

@joheriks
Copy link

Property blacklisted-packages is currently used to specifically exclude packages from scanning for annotations etc., while whitelisted-packages is used to exclusively include packages in scanning. These names do not convey the semantics of the properties very well, and there are indications that these terms are being perceived as increasingly dated by the developer community.

If done, documentation should be updated and support previous names as well for backwards compatibility. Other property naming related issues that may be relevant to consider at the same time are #634 and #637.
@jouni
Copy link
Member

jouni commented Dec 18, 2023

Suggested new property names:

  • blacklisted-packages → blocked-packages
  • whitelisted-packages → allowed-packages

@mshabarov mshabarov moved this to 🪵Product backlog in Vaadin Flow ongoing work (Vaadin 10+) Dec 18, 2023
@jouni jouni mentioned this issue Dec 18, 2023
Merged
mcollovati added a commit to vaadin/flow that referenced this issue Jan 8, 2024
@mcollovati @jouni
fix: replace 'blacklist' and 'whitelist' with 'blocked' and 'allowed'
91a751a 
Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
@mcollovati mcollovati mentioned this issue Jan 8, 2024
Merged
9 tasks
@github-project-automation github-project-automation bot moved this from 🪵Product backlog to Done in Vaadin Flow ongoing work (Vaadin 10+) Jan 9, 2024
@jouni
Copy link
Member

jouni commented Jan 11, 2024

I noticed that the whitelisted-packages property is used in a new project I created using our CLI tool, at least for a new Hilla project. We should update that once this change has been released.

mshabarov pushed a commit to vaadin/flow that referenced this issue Jan 15, 2024
@mcollovati @jouni @czp13
fix: replace 'blacklist' and 'whitelist' with 'blocked' and 'allowed' (…
be956a9 
…#18405)

Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
vaadin-bot pushed a commit to vaadin/flow that referenced this issue Jan 15, 2024
@mcollovati @jouni
@czp13 @vaadin-bot
fix: replace 'blacklist' and 'whitelist' with 'blocked' and 'allowed' (…
e307a85 
…#18405)

Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
vaadin-bot pushed a commit to vaadin/flow that referenced this issue Jan 15, 2024
@mcollovati @jouni
@czp13 @vaadin-bot
fix: replace 'blacklist' and 'whitelist' with 'blocked' and 'allowed' (…
e2e4793 
…#18405)

Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
vaadin-bot added a commit to vaadin/flow that referenced this issue Jan 15, 2024
@vaadin-bot @mcollovati
@jouni @czp13
fix: replace 'blacklist' and 'whitelist' with 'blocked' and 'allowed' (…
51c1ddb 
…#18405) (#18453)

Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Marco Collovati <marco@vaadin.com>
Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
vaadin-bot added a commit to vaadin/flow that referenced this issue Jan 15, 2024
@vaadin-bot @mcollovati
@jouni @czp13
fix: replace 'blacklist' and 'whitelist' with 'blocked' and 'allowed' (…
e488942 
…#18405) (#18452)

Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Marco Collovati <marco@vaadin.com>
Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
mcollovati added a commit to vaadin/flow that referenced this issue Jan 15, 2024
@mcollovati @jouni @czp13
fix: replace 'blacklist' and 'whitelist' with 'blocked' and 'allowed' (…
6ca1273 
…#18405)

Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
@mcollovati mcollovati mentioned this issue Jan 15, 2024
Merged
mcollovati added a commit to vaadin/flow that referenced this issue Jan 15, 2024
@mcollovati @jouni @czp13
fix: replace 'blacklist' and 'whitelist' with 'blocked' and 'allowed' (…
ca62950 
…#18405)

Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
@mcollovati mcollovati mentioned this issue Jan 15, 2024
Merged
mshabarov pushed a commit to vaadin/flow that referenced this issue Jan 15, 2024
@mcollovati @jouni @czp13
fix: replace 'blacklist' and 'whitelist' with 'blocked' and 'allowed' (…
c9d7798 
…#18405) (#18456)

Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
mshabarov pushed a commit to vaadin/flow that referenced this issue Jan 15, 2024
@mcollovati @jouni @czp13
fix: replace 'blacklist' and 'whitelist' with 'blocked' and 'allowed' (…
2c0b1de 
…#18405) (#18457)

Mark the existing methods as deprecated and introduce methods with new names.
Fall back to the old configuration properties if the new ones aren't used.

Fixes vaadin/spring#645

Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.3.33.

AB-xdev added a commit to xdev-software/vaadin-addon-template that referenced this issue Feb 16, 2024
@AB-xdev
Update application.yml
17aaf0e 
vaadin/spring#645
AB-xdev added a commit to xdev-software/vaadin-addon-template that referenced this issue Feb 16, 2024
@AB-xdev
Update release.yml
369cafa 
vaadin/spring#645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement needs design Released with Vaadin 23.3.33
Projects
Vaadin Flow enhancements backlog (Vaadin 10+)
Status: Done / Pending Release
Vaadin Flow ongoing work (Vaadin 10+)
Archived in project
Milestone
No milestone
3 participants
@jouni @joheriks @vaadin-bot