-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add an aria-label to avoid the dialog content being read twice #38
Conversation
Without an `aria-label` screen readers (NVDA, JAWS, VoiceOver) read the dialog content twice: once as a title and another time as the content. Depends on vaadin/vaadin-dialog#91 Fixes #29
bower.json, line 31 at r1 (raw file):
Let's not depend on new minor version unless a stable version is released before V11beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @vlukashov)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @alvarezguille and @vlukashov)
src/vaadin-confirm-dialog.html, line 227 at r2 (raw file):
_getAriaLabel(header) { return header || 'confirmation';
There is an option to set a custom header element into slot. Should we support this case as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
* add an aria-label to avoid the dialog content being read twice Without an `aria-label` screen readers (NVDA, JAWS, VoiceOver) read the dialog content twice: once as a title and another time as the content. Depends on vaadin/vaadin-dialog#91 Fixes #29
Without an
aria-label
screen readers (NVDA, JAWS, VoiceOver) read the dialog content twice: once as a title and another time as the content.Depends on vaadin/vaadin-dialog#91
Fixes #29
This change is