Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor and cleanup test helpers #787

Merged
merged 3 commits into from
Jan 21, 2021
Merged

test: refactor and cleanup test helpers #787

merged 3 commits into from
Jan 21, 2021

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Jan 15, 2021 •
edited
Loading

  • updated open and close test helpers to return a Promise to make some tests use async / await
  • removed the no longer used hacks related to the focus monkey patching (tests pass without those)
  • tried to get rid of using setTimeout in few places where it doesn't seem to be really needed
  • fixed it.only committed by accident 🙈 will consider adding a ESLint plugin to prevent that in future.

@web-padawan web-padawan self-assigned this Jan 15, 2021
@web-padawan web-padawan removed the request for review from tomivirkki January 21, 2021 10:43
@web-padawan web-padawan merged commit a84f71d into master Jan 21, 2021
@web-padawan web-padawan deleted the test-refactor branch January 21, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezguille alvarezguille alvarezguille approved these changes

Assignees

@web-padawan web-padawan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@web-padawan @alvarezguille