Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: bump test-runner, improve coverage #59

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Conversation

web-padawan
Copy link
Member

Updated the tests to improve coverage after trying mutation tests. See a report for remaining (not 100% covered) tests below.

Stryker report
#27. [Survived] BooleanLiteral
/Users/sergey/vaadin/vaadin-item/src/vaadin-item-mixin.js:76:67
-         this.addEventListener('focus', () => this._setFocused(true), true);
+         this.addEventListener('focus', () => this._setFocused(true), false);

Ran all tests for this mutant.
#31. [Survived] BooleanLiteral
/Users/sergey/vaadin/vaadin-item/src/vaadin-item-mixin.js:77:67
-         this.addEventListener('blur', () => this._setFocused(false), true);
+         this.addEventListener('blur', () => this._setFocused(false), false);

Ran all tests for this mutant.
#37. [Survived] StringLiteral
/Users/sergey/vaadin/vaadin-item/src/vaadin-item-mixin.js:82:39
-             document.removeEventListener('mouseup', mouseUpListener);
+             document.removeEventListener("", mouseUpListener);

Ran all tests for this mutant.
#44. [Survived] ConditionalExpression
/Users/sergey/vaadin/vaadin-item/src/vaadin-item-mixin.js:97:10
-         if (this.hasAttribute('active')) {
+         if (true) {

Ran all tests for this mutant.
#65. [Survived] StringLiteral
/Users/sergey/vaadin/vaadin-item/src/vaadin-item-mixin.js:124:37
-           this.setAttribute('focused', '');
+           this.setAttribute('focused', "Stryker was here!");

Ran all tests for this mutant.
#71. [Survived] StringLiteral
/Users/sergey/vaadin/vaadin-item/src/vaadin-item-mixin.js:126:42
-             this.setAttribute('focus-ring', '');
+             this.setAttribute('focus-ring', "Stryker was here!");

Ran all tests for this mutant.
#81. [Survived] StringLiteral
/Users/sergey/vaadin/vaadin-item/src/vaadin-item-mixin.js:141:36
-           this.setAttribute('active', '');
+           this.setAttribute('active', "Stryker was here!");

Ran all tests for this mutant.
#88. [Survived] Regex
/Users/sergey/vaadin/vaadin-item/src/vaadin-item-mixin.js:152:10
-         if (/^( |SpaceBar|Enter)$/.test(event.key) && !event.defaultPrevented) {
+         if (/( |SpaceBar|Enter)$/.test(event.key) && !event.defaultPrevented) {

Ran all tests for this mutant.
#89. [Survived] Regex
/Users/sergey/vaadin/vaadin-item/src/vaadin-item-mixin.js:152:10
-         if (/^( |SpaceBar|Enter)$/.test(event.key) && !event.defaultPrevented) {
+         if (/^( |SpaceBar|Enter)/.test(event.key) && !event.defaultPrevented) {

@web-padawan web-padawan merged commit 62998f3 into master Jan 25, 2021
@web-padawan web-padawan deleted the test-coverage branch January 25, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants